search

IchHabRecht / mask_export

Export your mask elements as extension
GNU General Public License v2.0
45 stars 27 forks source link

[TASK] Add return types, parameter types and clean up doc comments #188

Open simonschaufi opened 2 years ago

IchHabRecht commented 2 years ago

Hi @simonschaufi, Thank you very much for your pull request. Would you mind to give a short explanation why this pull request is necessary and what it resolved and/or improves?

simonschaufi commented 2 years ago

PHP annotations don't inform the developer if you pass a wrong data type into a function, for example, while parameter types declare which strict data type is expected and must be returned. If input or output doesn't match, a fatal error will happen, which in the end tells the developer that he did something wrong. This improves the code and fewer mistakes will happen when refactoring the code at some point in the future.

The core does the same thing for v12: https://forge.typo3.org/issues/97210

IchHabRecht commented 2 years ago

Hi @simonschaufi, Thanks again for this patch. As it seems not to be critical, I'll have a look as soon as I'm on this extension again.