Icinga / ansible-collection-icinga

Collection to setup and manage components of the Icinga software stack
Apache License 2.0
46 stars 35 forks source link

Unavailable Monitoring Plugin is not skipped #327

Closed Donien closed 1 month ago

Donien commented 1 month ago

If providing the name of a monitoring plugin that is not available on the current OS, it should be silently skipped.
So it should fail if the requested plugin is unknown BUT should skip if the requested plugin is simply unavailable for that specific OS/version.

Currently there is still a failure because comparisons are made in the wrong order.

Wrong order:

  1. Remove specific exclusions from available packages
  2. Add specific inclusions to available packages
  3. Check if all requested plugins are handled by the role

Correct order:

  1. Check if all requested plugins are handled by the role
  2. Remove specific exclusions from available packages
  3. Add specific inclusions to available packages