Icinga / ansible-playbooks

Ansible Playbook for Icinga 2
GNU General Public License v2.0
225 stars 122 forks source link

Code style fixes & cleanup -> towards fully automated install including module selection #101

Closed Bitblade closed 5 years ago

Bitblade commented 5 years ago

For Debian, I have created a playbook that can install Icinga2 and Icinga Web2 ui including modules such as Director and X509 in a fully automated way. (Including extra backends and kickstart).

I am in the process of rewriting / cleaning up my playbook in order to get it accepted here. This pull request is the first step towards that goal. I'm interested in the responses to this pull request so I can take that in mind for the next phases.

Bitblade commented 5 years ago

I'm no Git master, so forgive me if I'm wrong. But these snippets are from the web(1) playbook (which I think should be removed since web 1 is already EOL, but that's another issue).

However, I think you're refering to 49fd421, one of the 3 PR's that was merged today. It only included changes in icinga2_web2, which I believe I have accounted for in this PR.

Please see Bitblade@78e0338#diff-7799d63164ec0a636267eaa6bc49ea65R3