search

Icinga / ansible-playbooks

Ansible Playbook for Icinga 2
GNU General Public License v2.0
225 stars 122 forks source link

Removes the task restarting apache2 and icinga2 #79

Closed maccadia closed 5 years ago

maccadia commented 6 years ago

The task Restart HTTPD and Icinga2 to Apply the Configuration results in changes at each playbook execution. This is unnecessary. I have tested without this task and with some notify statements ; it works. Related issue: #50.

Note: this PR removes also a duplicate of task Configure Icinga2 Ido Mysql Feature

aflatto commented 6 years ago

@MAccadia Thank you for your contribution, Please test the changes also on RedHat based distribution.

We can not accept a changed for only a part of the functionality provided in the Role.

kaistian commented 6 years ago

Please test the changes also on RedHat based distribution.

This PR only changes icinga2_web2_ui_Debian_install.yml, a file only run on Debian based distribution. Why would this change need to be tested against RedHat when the file never run on these distribution?

maccadia commented 6 years ago

I think that what @aflatto had in mind was that the task(s) Restart {{ web_server_daemon }} and Icinga2 to Apply the Configuration in icinga2_web2_ui_RedHat_install.yml should be removed too in order to keep the same logic in both playbooks.

kaistian commented 6 years ago

I see. The problem I see with that approach is fewer people that can or are willing to contribute since they need to test on a unfamiliar distribution.