[IcingaWeb2] Generate and display setup token only when config.ini absent

Icinga / ansible-playbooks

Ansible Playbook for Icinga 2

GNU General Public License v2.0

225 stars 122 forks source link

[IcingaWeb2] Generate and display setup token only when config.ini absent #80

Closed maccadia closed 5 years ago

maccadia commented 6 years ago

The 2 tasks relative to the setup token for IcingaWeb2 only need to be ran during installation process. Once IcingaWeb2 is configured (i.e. when /etc/icingaweb2/config.ini exists), it's safe to skip these tasks.

:warning: this PR conflicts with PR #78 but include PR #78 suggested improvement. :warning: this PR hasn't been tested on RedHat

aflatto commented 6 years ago

@MAccadia Thank you for your contribution, Please test the changes also on RedHat based distribution.

We can not accept a changed for only a part of the functionality provided in the Role.

maccadia commented 6 years ago

I don't have any experience on RedHat systems. If you look at the code, I think the only reason this PR would fail on RedHat is if the path /etc/icingaweb2/config.ini is different. From what I've seen in the rpm package, it is the same path. Do you really think a test is needed ?