Also test built image - Githubissues

Icinga / docker-icinga2

Official Icinga 2 Docker images

GNU General Public License v2.0

67 stars 30 forks source link

Also test built image #66

Closed Al2Klimov closed 3 years ago

Al2Klimov commented 3 years ago

... via icinga2 daemon -C.

Not to accidentally miss new dependencies.

Al2Klimov commented 3 years ago

E.g. Boost Stacktrace.

julianbrost commented 3 years ago

Shouldn't this also be run by build.bash and for PRs in this repo?

julianbrost commented 3 years ago

Now that I think about this, we recently (with UoM parsing) had the situation where the tests would fail but the image was still pushed to Docker Hub. So I think it would make sense to additionally run make test.

Al2Klimov commented 3 years ago

The script already runs make test.

julianbrost commented 3 years ago

Well, yes and no, there's indeed a call to make test, but it doesn't work:

+ make test
Running tests...
Test project /i2cp/build
No tests were found!!!

Al2Klimov commented 3 years ago

... and we should definitively address that construction area as well.