search

Icinga / docker-icinga2

Official Icinga 2 Docker images
GNU General Public License v2.0
66 stars 30 forks source link

Added dnsutils as dependency for dig command #83

Closed vlcty closed 1 year ago

vlcty commented 1 year ago

The dig check command from the Icinga 2 ITL can not be used in the official docker container, because the dig command is not installed. Since there is no way to install software later on the dnsutils package providing the dig application should be added.

cla-bot[bot] commented 1 year ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @vlcty

- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case. - If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.
vlcty commented 1 year ago

I'll not sign a document with my full name and address just for a pull request on GitHub. I see three prossible ways:

1) You merge it anyway 2) You commit the change yourself 3) Do nothing and close this pull request

I'm happy with all three outcomes.

Al2Klimov commented 1 year ago

Colleagues, shall we auto-install recommended package dependencies instead?

julianbrost commented 1 year ago

Probably not for everything but in case of the monitoring-plugins package, it could make sense as ideally, they should all just work. But still would need a look over which packages this would additionally install.

Al2Klimov commented 1 year ago

Done better by #95.