Icinga / docker-icingaweb2

GNU General Public License v2.0
15 stars 11 forks source link

Re-build image on new mod versions #122

Open adn77 opened 5 months ago

adn77 commented 5 months ago

I use icinga/icingaweb2 as base for our install.

Unfortunately the image only gets build when there is a new icingaweb release. As the release of icingaweb is not increased when major plugins are updated (e.g. icingadbweb) I end up manually bind-mounting more current plugin releases into the container.

There is the main tag which appears to be build daily, but I didn't find any CI chain for this.

Is there any chance of building the icingaweb2 image more often or even linking the github actions once an included plugin gets updated?

oxzi commented 5 months ago

Unfortunately the image only gets build when there is a new icingaweb release. As the release of icingaweb is not increased when major plugins are updated (e.g. icingadbweb) I end up manually bind-mounting more current plugin releases into the container.

As get-mods.sh is part of the Dockerfile's build and not of the entrypoint, the modules won't get bumped. This is, as you rightly point out, a problem with outdated modules.

There is the main tag which appears to be build daily, but I didn't find any CI chain for this.

This repository here is used as a GitHub Action within icingaweb2: https://github.com/Icinga/icingaweb2/blob/main/.github/workflows/docker.yml

One easy fix would be to include a GitHub Action Job similar to those in icingaweb2 for github.event_name == 'release' to each module listed in get-mods.sh. Edit: The cron job/Action from icingaweb2 could also rebuild the latest tag on a daily basis.

Al2Klimov commented 3 months ago

The cron job/Action from icingaweb2 could also rebuild the latest tag

Good idea! IMAO we should let this happen weekly. People on the latest tag expect and want the latest stuff. In case of breaking changes in mods users even have multiple options:

CC @lippserd

adn77 commented 3 months ago

I'd be interested in testing your new ini-parsing PR in a :latest tag as well 🙂

Al2Klimov commented 2 months ago

TODO

jan-kantert commented 1 month ago

We also would like a new release with the latest icingadb(-web) version :-).