Closed julianbrost closed 2 years ago
@julianbrost @lippserd As far as I can tell the docker image is still not usable because of css build failures that this pull request is probably addressing.
a) am I right? b) if that its the case, what is currently holding this back? Getting the build actually working again would seem to be of rather big importance to me?
🎉
This commit introduces an explicit build mode in get-mods.sh that determines how the versions of external modules are selected.
Possible modes are:
release
: chooses latest release for each modulesnapshot
: uses a snapshot/development version for each module (if available)In
action.bash
, the mode is automatically set based on theGITHUB_REF
variable. For tags starting withv
(i.e. version tags likev2.9.0
) it isrelease
, other tag names are not supported. For branches it issnapshot
.Tests
master
https://github.com/julianbrost/icingaweb2/runs/5550768750?check_suite_focus=true
Uses branch name as tag for the Docker image, selects snapshot mode and selects dev versions:
v42.23
https://github.com/julianbrost/icingaweb2/runs/5550770184?check_suite_focus=true
Uses tag name with
v
prefix trimmed as tag for the Docker image, selects release mode and selects released versions:action-test-without-prefix
https://github.com/julianbrost/icingaweb2/runs/5550850774?check_suite_focus=true
Uses branch name as tag for the Docker image, selects snapshot mode and selects dev versions:
feature/action-test-with-prefix
https://github.com/julianbrost/icingaweb2/runs/5550852672?check_suite_focus=true
Uses branch name with
feature/
prefix trimmed as tag for the Docker image, selects snapshot mode and selects dev versions:fixes #62 closes #73 closes #78