Icinga / helm-charts

Kubernetes Helm charts to deploy a ready-to-use Icinga monitoring stack.
https://icinga.com
Apache License 2.0
9 stars 13 forks source link

use secrets for certificates #24

Closed CanisLupusLupus closed 1 year ago

CanisLupusLupus commented 1 year ago

This PR resolves issue #21.

Certificates are projected in containers using kubernets secrets and are mounted in /etc/icinga2-pki/<feature>/ directory. On enabling TLS/SSL in feature all certificates are required (i.e. ca, cert and key).

Sample configuration for elasticsearch:

icinga2:
  features:
    elasticsearch:
      enabled: true
      secretName: icinga-elasticsearch-secret
      enable_tls: true
      caSecretKey: ca
      certSecretKey: cert
      keySecretKey: key

Besides resolving issue #21 there are some more related changes:

CanisLupusLupus commented 1 year ago

I agree, it's better design to have separate secrets (and it also makes charts more flexible and easier to use...).

I'll go ahead and refactor the PR in coming days.

CanisLupusLupus commented 1 year ago

I've refactored the PR to use dedicated credSecret/tlsSecret instead of secretName.

mocdaniel commented 1 year ago

LGTM!