search

Icinga / icinga-notifications

Icinga Notifications: new and improved notifications and incident management for Icinga (work in progress, not ready for production yet)
GNU General Public License v2.0
9 stars 0 forks source link

Distinct "internal" Event Types #175

Closed oxzi closed 2 weeks ago

oxzi commented 2 months ago

The "internal" event type was used both for scheduled reevaluations and for initial reevaluations during startup. This type is currently being used at two different points for two distinct topics: scheduled reevaluations and initial reevaluations during startup.

This event type was now split into "reevaluation-scheduled" and "reevaluation-startup" to distinct those types.

To ensure database-level stability, the column type was changed from text to a custom enum.

Closes #162.

nilmerg commented 2 months ago

General question

No, no idea. I wouldn't parse it as such either, so if there's a prefix, it wouldn't have any meaning to Web.

julianbrost commented 2 months ago

General question

No, no idea. I wouldn't parse it as such either, so if there's a prefix, it wouldn't have any meaning to Web.

The incident history and event list currently display a little source icon. I don't know the exact logic for the incident history because it's currently not displayed for the events related to time-based escalations. Wouldn't it make sense to only display this for events that were externally submitted by the source and have an easy way to check this?

nilmerg commented 2 months ago

The source icon will be removed from the history alltogether (https://github.com/Icinga/icinga-notifications-web/issues/161) and the internal events won't have one either once https://github.com/Icinga/icinga-notifications-web/issues/157#issuecomment-1976805707 is done.