Icinga / icinga-notifications

Icinga Notifications: new and improved notifications and incident management for Icinga (work in progress, not ready for production yet)
GNU General Public License v2.0
9 stars 0 forks source link

Incident muting & notification suppression #200

Closed yhabteab closed 1 week ago

yhabteab commented 1 month ago

resolves #190

yhabteab commented 4 weeks ago

Have just rebased the PR to resolve the conflicts resulting from #114.

yhabteab commented 4 weeks ago

I have just rebased it and committed new changes separately 246f0f0.

yhabteab commented 3 weeks ago

Once again, I have found a bug where pending notifications, e.g. triggered by a downtime-start event, are not being sent ab7e482.

julianbrost commented 2 weeks ago

For the record: the recent changes pushed here should address something I discussed with @yhabteab yesterday: so far, the handling events like a downtime start without an incident was that if it was received from the Icinga 2 event stream, it would mute the object, which is also persisted in the database, but the event itself wouldn't make it to the database and result in an error. When catching up missed events, it wouldn't even mute the object if there was no incident.

yhabteab commented 2 weeks ago

There is still one annoying use case that I haven't been able to work around so far, and I don't know if it can be solved so easily.

yhabteab commented 2 weeks ago

Following yesterday's discussion, quite a lot of mysterious bugs began to appear, so the PR has been growing slowly. Please take another look!

julianbrost commented 2 weeks ago

@oxzi FYI: I don't expect further large changes to this PR, so feel free to have another look.

oxzi commented 1 week ago

Otherwise, I have successfully tested the PR and have not seen anything suspicious in the diff.