search

Icinga / icinga-powershell-framework

This PowerShell module will allow to fetch data from Windows hosts and use them for inventory and monitoring solutions. Together with the Icinga Web 2 module, a detailed overview of your Windows infrastructure will be drawn.
MIT License
74 stars 33 forks source link

Issue Pre-set Packages Repo during install is overwritten with default value #730

Open Wintermute2k6 opened 4 months ago

Wintermute2k6 commented 4 months ago

Issue Description

With a altered Pre-set Param [string]$IcingaRepository = 'https://packages.icinga.com/IcingaForWindows/stable/ifw.repo.json' inside of IcingaForWindows.ps1 and also during the Setup Phase the Icinga for Windows installer might fall back to the original default value https://packages.icinga.com/IcingaForWindows/stable/ifw.repo.json.

It defaults in the Base Install menu to the following:

===============================================================================================

[0] Connection => Connecting from this system [1] Certificate => Sign certificate manually on the Icinga CA master [2] Hostname => "example.host.com": FQDN (lowercase) [3] ParentZone => "master" [4] ParentNodes => "example.master1.com", "example.master2.com" [5] ParentAddress for "example.master1.com" => "191.168.178.1" [6] ParentAddress for "example.master2.com" => "191.168.178.2" [7] Port => "5665" [8] WindowsFirewall => Do not open Windows Firewall for incoming Icinga connections [9] ForceCertificateCreation => Do not enforce certificate creation [10] GlobalZones => Add "director-global" and "global-templates" zones [11] CustomZones => "" [12] AgentVersion => "release" [13] InstallAgent => Install Icinga Agent [14] AgentDirectory => "C:\Program Files\ICINGA2" [15] AgentUser => "NT Authority\NetworkService" [16] InstallPlugins => Install plugins [17] InstallService => Install Icinga for Windows Service [18] WindowsServiceDirectory => "C:\Program Files\icinga-framework-service" [19] StableRepository => "https://packages.icinga.com/IcingaForWindows/stable/ifw.repo.json" [20] InstallJEAProfile => Do not install JEA Profile [21] CAServer => "191.168.178.1" [22] InstallApiChecks => Install Api-Checks feature [23] ServiceRecovery => Enable automatic service recovery [24] DirectorSelfServiceConfig => "{ "address": "$ifw.hostaddress$" }"

[x] Exit [a] Hide Advanced [c] Continue [h] Help [l] Commands [m] Main [p] Previous

Input (Default c):

===============================================================================================

You need to set-again on [19] the correct Stable Repository .. even if it was set also before in the Settings in Stable Repository..

Icinga for Windows Management Console Copyright (c) 2024 Icinga GmbH | MIT User environment somewhere\user Icinga PowerShell Framework v1.12.3

Please enter the URL/Path for the location of your "Icinga Stable" Repository:

"https://example.own.reposerver/IcingaForWindows/stable/ifw.repo.json"

[x] Exit [c] Continue [d] Delete [h] Help [l] Commands [m] Main [p] Previous

Input (Default c) (1/1):

===============================================================================================

Probable Solution

It should at least be reflected that change might be needed instead of hiding the default value of the repo in the Install Command:

Icinga for Windows Management Console Copyright (c) 2024 Icinga GmbH | MIT User environment somewhere\user Icinga PowerShell Framework v1.12.3

Here is your configuration command for Icinga for Windows:

Install-Icinga -InstallCommand '{"IfW-ParentNodes":{"Values":["example.master1.com","example.master2.com"]},"IfW-Hostname":{"Selection":"1"},"IfW-Connection":{"Selection":"0"},"IfW-ParentZone":{"Values":["master"]},"IfW-ParentAddress":{"Values":{"example.master2.com":["192.168.178.2"],"example.master1.com":["192.168.178.1"]}}}'

[x] Exit [c] Continue [h] Help [l] Commands [m] Main [p] Previous

Input (Default c) (1/1):