search

Icinga / icinga-powershell-plugins

A collection of Windows check plugins for the Icinga PowerShell Framework
GNU General Public License v2.0
51 stars 28 forks source link

Invoke-IcingaCheckCPU wrong overall load calculation if more than one cpu socket is present #381

Closed audiocoach closed 3 months ago

audiocoach commented 8 months ago

Hello,

the Invoke-IcingaCheckCPU overall load calculation is wrong if more than one cpu socket ist present. The core total values from the sockets are just summarized but not devided through the number of sockets.

image

My environment: Icinga 2.14.1 Icinga Web 2.12.1 Icinga Director 1.11 Icinga for Windows 1.11.1

BTMichel commented 7 months ago

We are also negatively affected by this issue after updating the plugins: image

All our thresholds are now incorrect and would need manual configuration for each host according to socket count. On setups with thousands of hosts, this is not manageable unfortunately.

We propose that the overall load calculation should be an average of all sockets.

bfenda commented 7 months ago

I do also agree with the previous posts. I would expect the overall cpu to be the average of all sockets, as this tends to conflict with a single threshold used for each socket and overall:

image

KreativeKrise commented 7 months ago

Is the overall load supposed to be a maximum of 100%? If so, then the bug does not only apply to systems with multiple sockets. On my 1-socket system with 4 CPU cores, I currently also have a overall load of over 100%.

LordHepipud commented 3 months ago

This is now fixed, as there is another argument that will tell the plugin to report the average of all sockets or the sum.

Both metrics are useful, depending on the environment. Thats why we implemented that with v1.12.0