search

Icinga / icinga-web

Icinga Web 1.x, the old new web interface (EOL 31.12.2018)
22 stars 11 forks source link

[dev.icinga.com #10955] redundant one-liner #1372

Closed icinga-migration closed 6 years ago

icinga-migration commented 8 years ago

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10955

Created by roberte on 2016-01-12 03:37:46 +00:00

Assignee: (none) Status: New Target Version: (none) Last Update: 2016-01-12 03:37:46 +00:00 (in Redmine)

Icinga Version: 1.11.1
Icinga Web Version: 1.11.1
IDO Version: 1.11.1
OS Version: linux
DB Type: PostgreSQL
DB Version: 1
Browser Version: 1

icinga-web/app/modules/AppKit/lib/database/models/NsmUser.php

the function __updatePassword(); line two of this function seems redundant.

private function __updatePassword($password) { $thisuser_salt = $this>__createSalt($this->user_name); hash_hmac(self::HASH_ALGO, $password, $thisuser_salt); // <---------------- $thisuser_password = hash_hmac(self::HASH_ALGO, $password, $this>user_salt); }

kthxbie

dnsmichi commented 6 years ago

Thx, but 1.x won't receive code quality patches anymore.