[dev.icinga.com #3189] Bad place for 'Details' Button in HostStatus cronk (currrent gitmaster b607..)

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3189

Created by ossmon on 2012-09-26 11:15:23 +00:00

Assignee: mfriedrich Status: Resolved (closed on 2012-10-04 13:32:49 +00:00) Target Version: 1.8 Last Update: 2012-10-04 13:32:49 +00:00 (in Redmine)

Icinga Version: 1.7.0
Icinga Web Version: 1.8.0
IDO Version: 1.7.0
OS Version: RHEL6.1
DB Type: MySQL
DB Version: 5.1.61
Browser Version: Firefox 11.0

---

In the current git master, the 'Details' button for the Host Info Box was again moved as a column in the grid. I think it is not a good idea because:

• it is not the same design as in the ServiceStatus cronk
• it overload the grid
• in my firefox this column flash again after the page is loaded

In a previous git master, it was in the "Expand" line, left from the 'Services' button and it was better

Attachments

• HostStatusCronkDetails.JPG ossmon - 2012-09-26 11:15:24 +00:00
• icinga_web_1.8_hoststatus_details_fixed.png mfriedrich - 2012-10-04 13:17:14 +00:00
• 0001-details-icon-fix-for-hoststatus-same-as-servicestatu.patch mfriedrich - 2012-10-04 13:17:14 +00:00
• icinga_web_1.8_hoststatus_details.png mfriedrich - 2012-10-04 13:17:14 +00:00
• icinga_web_1.8_servicestatus_details.png mfriedrich - 2012-10-04 13:17:14 +00:00

Changesets

2012-10-04 13:31:31 +00:00 by mfriedrich 1c572f095a18ee3bae211a98cbf7196f5ca54fc6

details icon fix for hoststatus (same as servicestatus) fixes #3189

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>

2012-10-05 09:22:51 +00:00 by mfriedrich a44da010c1f3f833e30ba875033ec4d7efc777d0

details icon fix for hoststatus (same as servicestatus) fixes #3189

Signed-off-by: Michael Friedrich <michael.friedrich@gmail.com>

[icinga-migration]

Updated by jmosshammer on 2012-09-30 11:41:46 +00:00

What happens if you right click on the subcolumn and reset the view?

[icinga-migration]

Updated by ossmon on 2012-09-30 15:06:02 +00:00

What do you mean with subcolumn and reset (screenshot ?) ? (i'am at home and i can try tomorrow at the office)

[icinga-migration]

Updated by wolle on 2012-10-04 13:00:29 +00:00

Change Line 66 in app/modules/Cronks/data/xml/grid/icinga-host-template.xml

--- app/modules/Cronks/data/xml/grid/icinga-host-template.xml   2012-10-04 14:56:46.000000000 +0200
+++ app/modules/Cronks/data/xml/grid/icinga-host-template.xml.fix       2012-10-04 14:57:13.000000000 +0200
@@ -66,7 +66,7 @@

-                        sub
+                        sub

                             Cronk.grid.handler.Info.host

[icinga-migration]

Updated by wolle on 2012-10-04 13:12:22 +00:00

mistake, this works:

sub

[icinga-migration]

Updated by mfriedrich on 2012-10-04 13:17:14 +00:00

• File added _icinga_web_1.8_hoststatus_detailsfixed.png
• File added 0001-details-icon-fix-for-hoststatus-same-as-servicestatu.patch
• File added _icinga_web_1.8_hoststatusdetails.png
• File added _icinga_web_1.8_servicestatusdetails.png
• Target Version set to 1.8

I'd like to propose a different fix.

currently, it looks like this

• servicestatus

• hoststatus

by changing the host template to the exact same as the service template with the attached patch, it looks like

• hoststatus fixed

[icinga-migration]

Updated by mfriedrich on 2012-10-04 13:29:23 +00:00

• Category set to Interface Features
• Status changed from New to Assigned
• Assigned to set to mfriedrich

[icinga-migration]

Updated by mfriedrich on 2012-10-04 13:32:49 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

fix is in git master, web devs aware of it.