Feature/tags for elasticsearchwriter

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.

https://icinga.com/docs/icinga2/latest

GNU General Public License v2.0

2k stars 574 forks source link

Feature/tags for elasticsearchwriter #10074

Open SebastianOpeni opened 3 months ago

SebastianOpeni commented 3 months ago

Offers to add additional tags to entries written by the ElasticSearchWriter.

As discussed with Eric at the icinga summit we are submitting this feature. Please revise the code and let us know if there is something we need to improve. otherwise we would be happy for timely merge.

fixes #6837

cla-bot[bot] commented 3 months ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @SebastianOpeni

- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case. - If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

SebastianOpeni commented 3 months ago

The CLA should be signed now.

bobapple commented 3 months ago

@cla-bot check

SebastianOpeni commented 2 weeks ago

Hi thanks for your review :) I am currently working on your remarks but might have some questions beforehand.

SebastianOpeni commented 1 week ago

Thanks for your answers in the review. I tried to implement everything as requested.

yhabteab commented 1 week ago

Apart from https://github.com/Icinga/icinga2/pull/10074#discussion_r1771206872, code wise it should be fine now, I haven't tested it with a actual ElasticSearch instance though, but till I get the time, some of my colleagues might want a look at this as well.