search

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2.03k stars 578 forks source link

Buffer is flushed🚽 after every single Redis query #10100

Open Al2Klimov opened 4 months ago

Al2Klimov commented 4 months ago

Describe the bug

Even given a bulk of queries, RedisConnection#WriteItem() loops them calling WriteOne(). The latter calls WriteRESP() and async_flush().

Expected behavior

Write everything queued, flush once.

Your Environment

c5c7925d8

Additional context

While more async I/O may even reduce mutex contention, this is not what our buffered streams are for.