On Windows, don't create C:\Program Files\Icinga2\var during MSI build

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.

https://icinga.com/docs/icinga2/latest

GNU General Public License v2.0

2k stars 574 forks source link

On Windows, don't create C:\Program Files\Icinga2\var during MSI build #10137

Open Al2Klimov opened 1 month ago

Al2Klimov commented 1 month ago

Test

https://git.icinga.com/packaging/windows-icinga2/-/jobs/580745 neither created it in the build env, nor the MSI, installed on a separate VM, misses any dirs listed in files changed here. 👍

julianbrost commented 1 month ago

misses any dirs listed in files changed here

I'm not sure what this is trying to say? Is this good? Is it bad? Does it miss a negation?

Anyway, doesn't that imply that all of these variables are set to broken paths on Windows in general as it should always be C:\ProgramData\Icinga2\var, not C:\Program Files\Icinga2\var?

Al2Klimov commented 1 month ago

Test II

On two independent machines w/o Icinga 2 installed, my non-admin could build this branch:

$env:BITS = 64
$env:CMAKE_BUILD_TYPE = "RelWithDebInfo"
& .\tools\win32\load-vsenv.ps1
powershell.exe .\tools\win32\configure.ps1
& powershell.exe .\tools\win32\build.ps1
& powershell.exe .\tools\win32\test.ps1

👍