Sort config types by their load dependencies once

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.

https://icinga.com/docs/icinga2/latest

GNU General Public License v2.0

2k stars 574 forks source link

Sort config types by their load dependencies once #10148

Closed yhabteab closed 1 week ago

yhabteab commented 3 weeks ago

This PR is basically the same as #10003, but since @Al2Klimov is out for this week, we need to get it done. So I've cherry-picked the commits from there and added some additional commits to address the requested changes in that PR.

Loosely depends on https://github.com/Icinga/icinga2/pull/10169

closes #10003

yhabteab commented 1 week ago

Oh! We can't backport this to 2.13.x due to https://github.com/Icinga/icinga2/commit/33e609d7919b79fb2ae7877ab367389045b4dec9.

Al2Klimov commented 1 week ago

Do you mean "We can't backport this to 2.13.x without https://github.com/Icinga/icinga2/commit/33e609d7919b79fb2ae7877ab367389045b4dec9"?

yhabteab commented 1 week ago

Just rebased it!

yhabteab commented 1 week ago

Looks fine and should do the job, I just don't want to do a quick approve + merge right before leaving for vacation and another pair of eyes shouldn't hurt.

Since you're back now :) and the PR is still open, do you have any change requests? Otherwise, please give your approval as well.