search

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2k stars 574 forks source link

Overhaul Utility::FormatDateTime() #10165

Closed Al2Klimov closed 1 week ago

Al2Klimov commented 2 weeks ago
yhabteab commented 1 week ago

I don't think we should backport this to 2.13.x as it requires some codes that were not backported for their own reasons. I mean, do we really need this for a 2.13.10 bugfix release at all?

julianbrost commented 1 week ago

@Al2Klimov Why did you need to pull in the other PRs, i.e. what needs C++14?

Al2Klimov commented 1 week ago

'quoted' is not a member of 'std' [until C++14]

– https://github.com/Icinga/icinga2/actions/runs/10940187059/job/30372035371#step:4:2275

julianbrost commented 1 week ago

That function is only used in the tests three times for the error messages and can easily be replaced by adding the quotes manually to the surrounding strings. That sounds much more reasonable to me than bumping the C++ version for the old support branch just for this.