search

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2.01k stars 576 forks source link

ITL: Adding Extra-Opts to nagios plugins #7630

Open netphantm opened 4 years ago

netphantm commented 4 years ago

I need to add Extra-Opts to check_http (https://www.monitoring-plugins.org/doc/extra-opts.html), as we are doing some checks through a proxy to check if host is reachable externally. A username/password combination is needed, so I included a file which contains the creds. I added following lines to the command-plugins.conf:

    "--extra-opts" = {
          value = "$http_extra_opts$"
          description = "Add extra options to check (like proxy credentials file)"
    }

I wanted to extend the ITL with this, but then I realized that a lot of nagios plugins have this parameter. Should it be added to all of them manually or can you suggest a better way to do this?

dnsmichi commented 4 years ago

Preferably all CheckCommand definitions receive this parameter in a PR. Which is quite some effort to stem with the ITL changes and doc table updates.

Al2Klimov commented 4 years ago

Hello @netphantm and thank you for reporting!

Feel free to submit a PR with the affected CheckCommands. A lot of doesn't mean all.

And no, there's no better way to do this.

Best, AK

netphantm commented 4 years ago

I will, I just had no time yet..