Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
2.03k stars 578 forks source link

InfluxdbWriter chokes on perfdata "U" #9282

Open joernott opened 2 years ago

joernott commented 2 years ago

Describe the bug

I am getting a lot of warnings in my icinga2 logs like this:

warning/InfluxdbWriter: Ignoring invalid perfdata for checkable 'dev-bas1-pos-v01.sf-rz.de!postgres_patroni_dev_01_tst_longest_query' and command 'check_pgactivity' with value: 'testdb max'=Us;60;90

Looking at https://nagios-plugins.org/doc/guidelines.html#AEN200, the value "U" is perfectly legitimate here

To Reproduce

  1. set up a check which will return "U" as value in the performancedata (check_pgactivity works fine with the longest_query)
  2. run the check and look into the logs

Expected behavior

I would love to turn off those warnings in the icinga logs (only for value U) or have InfluxWriter insert something like null instead of failing/complaining.

Your Environment

Include as many relevant details about the environment you experienced the problem in

Al2Klimov commented 2 years ago

value may be a literal "U" instead, this would indicate that the actual value couldn't be determined

joernott commented 2 years ago

Yes, that is what the check is sending and Icinga is passing to the writer. So I would expect it to handle that value without spamming the logs.