search

Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
1.99k stars 573 forks source link

Icinga DB: cancel_time in downtime history should not be 0 #9612

Open julianbrost opened 1 year ago

julianbrost commented 1 year ago

The following sends a 0 value for cancel_time in the downtime history if the downtime wasn't actually cancelled: https://github.com/Icinga/icinga2/blob/master/lib/icingadb/icingadb-objects.cpp#L1923

This will then write a 0 timestamp to the corresponding column in the database rather than a NULL value. Icinga 2 should either write null to Redis or omit the key in the JSON altogether if the downtime wasn't cancelled.

refs https://github.com/Icinga/icingadb-web/issues/691

Al2Klimov commented 1 year ago

@yhabteab Are you actually working on this?

yhabteab commented 1 year ago

@yhabteab Are you actually working on this?

Nope!

Al2Klimov commented 1 year ago

There is a workaround in place at the moment so it’s NOT a production issue: