Icinga / icinga2

The core of our monitoring platform with a powerful configuration language and REST API.
https://icinga.com/docs/icinga2/latest
GNU General Public License v2.0
1.99k stars 573 forks source link

plugins-contrib.d/web.conf check_ssl_cert deprecated warnings #9661

Closed jg-basis closed 3 months ago

jg-basis commented 1 year ago

Describe the bug

Changes to options by check_ssl_cert are leading to deprecated warning in icinga. In the /itl/plugins-contrib.d/web.conf file there are options that cause the issue (lines 399-405).

To Reproduce

  1. Deploy latest version of check_ssl_cert from https://github.com/matteocorti/check_ssl_cert (or a version >= 2.47.0 where deprecated warnings were introduced)
  2. Define a normal ssl_cert check service - in our case we also had "vars.ssl_cert_altnames = true" defined
  3. Execute the check.

Expected behavior

No warnings displayed on the service check about deprecated options.

Screenshots

Displaying of warnings.

Command line option '--altnames' is deprecated: Enabled by default
Command line option '-n' is deprecated: Use '-m'

Your Environment

jg-basis commented 1 year ago

This code change will fix the issue on my environment Change -n to -m

Remove this part "--altnames" = { set_if = "$ssl_cert_altnames$" description = "Matches the pattern specified in -n with alternate" }