Icinga / icingadb-web

Icinga DB Web – UI for Icinga DB – Provides a graphical interface to your Icinga monitoring
GNU General Public License v2.0
67 stars 22 forks source link

Show last host/service comment in a popup in detailed mode #231

Closed nilmerg closed 3 years ago

nilmerg commented 3 years ago

Is your feature request related to a problem? Please describe.

Currently we only indicate in detailed list mode that a host or service has a comment. But who authored it and the comment itself is not shown.

Describe the solution you'd like

Upon hovering over the comment icon in the list item's footer, a popup should open showing the comment's author and the comment's content.

Additional context

nilmerg commented 3 years ago

Above I've added links showing the current way of indicating that a comment exists. This is far from ideal at the moment, as it runs a subquery for each item in the list. What I'd like to have instead, is that the last comment for each list entry is already fetched with the main database query.

For this you'll have to implement a new relation last_comment in the HostState and ServiceState models, which is joined by a LEFT join. This relation needs to be selected then as part of the main query, take a look at the with() call in the respective controller/index action for this.

The popup should be a rich popup. Not just a standard title. So it should be a box with the enlarged comment icon maybe and a border around it that points to the hovered icon with a directional indicator? You should probably first draw a mockup/picture of this before actually implementing it and show it @flourish86, or ask him to do that for you.

flourish86 commented 3 years ago

Something like this.

Some notes:

Desktop