search

Icinga / icingadb-web

Icinga DB Web – UI for Icinga DB – Provides a graphical interface to your Icinga monitoring
GNU General Public License v2.0
67 stars 22 forks source link

Optimize scheduling source alignment #256

Closed flourish86 closed 3 years ago

flourish86 commented 3 years ago

Screen Shot 2021-08-23 at 16 19 18

nilmerg commented 3 years ago

Please include what to optimize.

flourish86 commented 3 years ago

.key and .value should either be aligned to baseline (1) or we should use the same font-sizes as in the custom vars table (2).

Also the colon (:) can be left out, since key and value are differentiated by font style.

This would solve option (1):

.icinga-module.module-icingadb .check-statistics .card-footer .key {
  …
  align-self: baseline;
  line-height: calc(1/.83333333 * 1.5);
}
nilmerg commented 3 years ago

The font-sizes follow the same rules as the vertical-key-value widgets. It's just a horizontal-key-value now.

The colon cannot be left out. It's a structural element, not a style element. And style is not structural. In the downtime list items we also didn't just remove the colon but replaced it with a semantically correct conjunction (for).

flourish86 commented 3 years ago

The titles for downtimes is something completely different, because list item titles are meant to be full sentences.

This looks perfect to me.

Screen Shot 2021-08-30 at 16 02 20

Compared to this

Screen Shot 2021-08-30 at 16 19 40

nilmerg commented 3 years ago

because list item titles are meant to be full sentences.

And that is this exactly not, a full sentence, hence the colon.