Icinga / icingadb-web

Icinga DB Web – UI for Icinga DB – Provides a graphical interface to your Icinga monitoring
GNU General Public License v2.0
67 stars 22 forks source link

Host/Service group right column view mode switcher not working correctly #284

Closed sukhwinder33445 closed 3 years ago

sukhwinder33445 commented 3 years ago

Describe the bug

Host/Service group right column view mode switcher not working correctly. If you change the view mode in the right column, this affects the left column.

To Reproduce

  1. Host Groups.
  2. Select a group.
  3. Select a host.
  4. Select a group in host detail view (right column).
  5. Change the view mode of view mode switcher (right column).

Screenshot 2021-08-25 at 15 20 48

nilmerg commented 3 years ago

this affects the left column

The left column is closed, for me. Is that what you mean?

sukhwinder33445 commented 3 years ago

No. When you change the view mode in the right column for the first time, the view mode for the left column changes (this should not happen). And the right side still remain as it was before.

nilmerg commented 3 years ago

Nope. Left column closes and right column (then the only col) updates correctly. The left column shouldn't close of course, but the update is as of now working as intended. See #260 for that.

sukhwinder33445 commented 3 years ago

@Yonas-net tested this and it works fine on his device. On my device it still doesn't work (maybe it takes too long to load 😆 ).

nilmerg commented 3 years ago

This is weird.

Here's definitely something wrong with what submitting the viewmode switcher will update.

yhabteab commented 3 years ago

That's exactly what I was going to write 😆 . This also applies to Hosts => Host services 😔 . Without the view param in /icingadb/hosts everything works as expected.

yhabteab commented 3 years ago

The left column shouldn't close of course,

I think this is actually intended, that when col1 and col2 do have the exact same url path, col1 is supposed to be shifted. See here.

nilmerg commented 3 years ago

This is weird.

This is fixed it seems with #331.

I think this is actually intended

It's not. It's a side-effect of an intended effect. The part you've linked is intended to cover the case that a configuration form is on the right and redirects back to list upon successful submit. Then the right column is indeed not required anymore and the "redirect" is loaded into the left column. But here it's not a configuration form. So this is a bug in Icinga Web 2.

yhabteab commented 3 years ago

The view mode switcher is also somehow a configuration form. And the left column closes only when the view mode is submitted, so I am not sure how to distinguish this from the others.

nilmerg commented 3 years ago

This will still happen in some situations as long as https://github.com/Icinga/icingaweb2/issues/4554 isn't fixed.