search

Icinga / icingaweb2-module-businessprocess

Create top-level views of your applications in a graphical editor. Rules express dependencies between existing hosts and services and let you alert on application level. Business processes are displayed in a tree or list overview.
https://icinga.com/docs/businessprocess/latest
GNU General Public License v2.0
108 stars 44 forks source link

Simulation doesn't work for imported sub processes in a super BP #229

Open dnsmichi opened 5 years ago

dnsmichi commented 5 years ago

Expected Behavior

Simulation with state overrides also works with imported linked BPs.

Current Behavior

Imported sub BPs don't allow you editing and simulate a state change. You have to navigate back into the main BP which makes the feature kind of hard to use in the "super BP".

Possible Solution

Steps to Reproduce (for bugs)

  1. Create 2 BPs, web and database, root node production with some services in it
  2. Create a super BP, with root nodes web and database
  3. Import the existing BPs into the new root nodes
  4. Unlock editing and try to simulate a state change - this icon doesn't exist in this view

Screen Shot 2019-04-10 at 16 59 29

  1. Navigate back into the database or web BP - you can edit and simulate the BP

Screen Shot 2019-04-10 at 17 02 18

Context

Building multiple layers of BPs.

web.conf

### Business Process Config File ###
#
# Owner           : icingaadmin
# AddToMenu       : yes
# Statetype       : soft
#
###################################

production = web-host-1;http & web-host-2;http
display 1;production;production

database.conf

### Business Process Config File ###
#
# Description     : All database checks for our production cluster
# Owner           : icingaadmin
# AddToMenu       : yes
# Statetype       : soft
#
###################################

production = mysql-host-1;mysql-connection-time & mysql-host-2;mysql-connection-time
display 1;production;production

shop.conf

### Business Process Config File ###
#
# Owner           : icingaadmin
# AddToMenu       : yes
# Statetype       : soft
#
###################################

database = @database:production
display 1;database;database
web = @web:production
display 1;web;web

Your Environment

nilmerg commented 5 years ago

I've looked into this prior v2.2 but the way it's implemented I was unable to adjust this in time. The simulation feature is tightly connected with how processes are edited. Internally this is separated on a per configuration basis. Not so easy to change.

dnsmichi commented 5 years ago

Agreed, it likely requires larger rewrites. In earlier versions of the BP module, is was easier to simulate since the whole 'unlock editing, store config, diff config` mechanism wasn't that complex. That's mostly the reason why I've created this issue, BP simulation is one of the key features imho :)

Thomas-Gelf commented 5 years ago

Hint: the toggle used to be labelled "Unlock", this has been changed to "Unlock Editing"

nilmerg commented 5 years ago

That doesn't change the fact that it's an additional click (hidden feature), which this issue isn't even about but #226 is. :man_shrugging:

Thomas-Gelf commented 5 years ago

@nilmerg: you're right, my comment relates to #226 - sorry for the confusion. Changing that label might help arguing in #226 ;-)

MarcusCaepio commented 2 years ago

Hi all, I am re-using existing processes too and just stepped over this issue. Any plans to work on this in the near future?

nilmerg commented 2 years ago

No plans, yet.