Support custom ordering of nodes

Icinga / icingaweb2-module-businessprocess

Create top-level views of your applications in a graphical editor. Rules express dependencies between existing hosts and services and let you alert on application level. Business processes are displayed in a tree or list overview.

https://icinga.com/docs/businessprocess/latest

GNU General Public License v2.0

108 stars 44 forks source link

Support custom ordering of nodes #384

Closed nilmerg closed 1 year ago

nilmerg commented 1 year ago

resolves #252 closes #297

requires https://github.com/Icinga/ipl-web/pull/173

nilmerg commented 1 year ago

Things to test:

Does the sort control work intuitively?
- Especially in conjunction with manually ordered processes?
Do forms still work fine with respect to style and layout? (Didn't change, only somewhat technically)
Do process diffs look ... clean? (Add a new node, remove one, reorder something and look at the diff and evaluate whether there are unnecessary changes)

flourish86 commented 1 year ago

The sorting works ok so far.

I'm sorry to say, but I discovered some problems, though.

1) The first is meant to be addressed with the commit 954ef8b

It addresses a problem, where you had to click on the name to "enter" that node.

2) The second problem is a result of that. Now the cursor won't indicate, that the tile would be draggable.

3) There's still a delay (at least in Safari) until the tile will be draggable again, after being dragged and dropped.

nilmerg commented 1 year ago

Okay. But this PR doesn't address anything related to drag and drop. I've pushed your changes separately: #385