search

Icinga / icingaweb2-module-businessprocess

Create top-level views of your applications in a graphical editor. Rules express dependencies between existing hosts and services and let you alert on application level. Business processes are displayed in a tree or list overview.
https://icinga.com/docs/businessprocess/latest
GNU General Public License v2.0
108 stars 44 forks source link

Escape semicolons in node names #388

Closed nilmerg closed 1 year ago

nilmerg commented 1 year ago

fixes #312 closes #354

nilmerg commented 1 year ago

Changed my mind regarding how we handle semicolons. With #387 I'm gonna overhaul the validation of nodes and as my goal is that invalid suggestions shouldn't be made, nodes with semicolons wouldn't be visible anymore to the user and hence no explanation why. That's why I looked into the escaping again and tried to quickly implement it. My manual tests succeeded and the small unittest I've included also succeeds.

Though, please take an additional look @sukhwinder33445.