Icinga / icingaweb2-module-director

The Director aims to be your new favourite Icinga config deployment tool. Director is designed for those who want to automate their configuration deployment and those who want to grant their “point & click” users easy access to the configuration.
https://icinga.com/docs/director/latest
GNU General Public License v2.0
413 stars 203 forks source link

Link to a rule in service->modify throws exception #2572

Closed kdeb closed 2 years ago

kdeb commented 2 years ago

Current Behavior

If you select the link in a service (overview/services/<service which was created by a rule>/modify) which leads to the rule with which a service was created, there is an exception.

( ! )  Fatal error: Uncaught Error: Call to a member function toString() on  null in  /usr/share/icingaweb2/modules/director/application/controllers/ServiceController.php  on line 254

( ! ) Error: Call to a member function toString() on null in /usr/share/icingaweb2/modules/director/application/controllers/ServiceController.php on line 254

1 | 0.0001 | 407224 | {main}(  ) | .../index.php:0
2 | 0.0003 | 431288 | require_once( '/usr/share/php/Icinga/Application/webrouter.php' ) | .../index.php:4
3 | 0.0309 | 4512320 | Icinga\Application\Web->dispatch(  ) | .../webrouter.php:107
4 | 0.0309 | 4512320 | Zend_Controller_Front->dispatch(  ) | .../Web.php:304
5 | 0.0317 | 4567912 | Icinga\Web\Controller\Dispatcher->dispatch(  ) | .../Front.php:937
6 | 0.0353 | 5123872 | Icinga\Module\Director\Controllers\ServiceController->__construct(  ) | .../Dispatcher.php:59
7 | 0.0382 | 5456240 | Icinga\Module\Director\Controllers\ServiceController->init(  ) | .../ActionController.php:165
8 | 0.0382 | 5456240 | Icinga\Module\Director\Controllers\ServiceController->init(  ) | .../ServiceController.php:46
9 | 0.0569 | 7371424 | Icinga\Module\Director\Controllers\ServiceController->loadOptionalObject(  ) | .../ObjectController.php:90
10 | 0.0569 | 7371456 | Icinga\Module\Director\Controllers\ServiceController->loadObject(  ) | .../ObjectController.php:497

( ! )  Fatal error: Uncaught Zend_Controller_Response_Exception: Cannot send  headers; headers already sent in , line 0 in  /usr/share/icingaweb2/library/vendor/Zend/Controller/Plugin/Broker.php  on line 332

( ! ) Zend_Controller_Exception: Cannot send headers; headers already sent in , line 0#0 /usr/share/icingaweb2/library/vendor/Zend/Controller/Response/Abstract.php(115): Zend_Controller_Response_Abstract->canSendHeaders() #1 /usr/share/php/Icinga/Web/Controller/ActionController.php(505): Zend_Controller_Response_Abstract->setHeader() #2 /usr/share/php/Icinga/Web/Controller/ActionController.php(480): Icinga\Web\Controller\ActionController->postDispatchXhr() #3 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(512): Icinga\Web\Controller\ActionController->postDispatch() #4 /usr/share/php/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch() #5 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch() #6 /usr/share/php/Icinga/Application/Web.php(471): Zend_Controller_Front->dispatch() #7 [internal function]: Icinga\Application\Web->Icinga\Application\{closure}() #8 {main} in /usr/share/icingaweb2/library/vendor/Zend/Controller/Plugin/Broker.php on line 332

Call Stack
1 | 0.0596 | 7517112 | Icinga\Application\Web->Icinga\Application\{closure:/usr/share/php/Icinga/Application/Web.php:454-473}(  ) | .../Web.php:0
2 | 0.0596 | 7512008 | Zend_Controller_Front->dispatch(  ) | .../Web.php:471

Steps to Reproduce (for bugs)

2022-07-22 14_11_37-Icinga Web

2022-07-22 13_28_51-Icinga_exception

Your Environment

log1-c commented 2 years ago

See here: https://github.com/Icinga/icingaweb2-module-director/issues/2554 Fix will come with v1.10 or you cherry-pick that commit.