search

Icinga / icingaweb2-module-director

The Director aims to be your new favourite Icinga config deployment tool. Director is designed for those who want to automate their configuration deployment and those who want to grant their “point & click” users easy access to the configuration.
https://icinga.com/docs/director/latest
GNU General Public License v2.0
413 stars 203 forks source link

Description for states (OK, WARNING...) is the same in notifications (correct) and dependencies (wrong) #2684

Open RincewindsHat opened 1 year ago

RincewindsHat commented 1 year ago

Expected Behavior

The help text for the states in the Dependency forms should say something along the lines of "The host/service states for which the dependency should not trigger".

Current Behavior

The description/help text of the state in the Dependency forms are "The host/service states you want to get notifications for" which is obviously wrong. The reason for this is like the re usage of the addEventFilterElements function ( https://github.com/Icinga/icingaweb2-module-director/blob/400bf8c0b0d6681f20b4f314bad760d49323379f/library/Director/Web/Form/DirectorObjectForm.php#L1668 ) where this text is hardcoded.

log1-c commented 1 year ago

Had this misconception of that sentence for a long time as well. But it is actually correct (and then same outcome like your proposed sentence, just from looked at from the other side), though imo it can be easily misunderstood.

In a dependency you generally set the states of the parent host/service during which the child hosts/service should be considered "reachable" (dependency not failed/triggered) and thus send notifications for problems.