search

Icinga / icingaweb2-module-director

The Director aims to be your new favourite Icinga config deployment tool. Director is designed for those who want to automate their configuration deployment and those who want to grant their “point & click” users easy access to the configuration.
https://icinga.com/docs/director/latest
GNU General Public License v2.0
413 stars 201 forks source link

Do not use Internal.run_with_activation_context (Icinga DSL) #2699

Open Al2Klimov opened 1 year ago

Al2Klimov commented 1 year ago

Expected Behavior

We'd like to un-expose the Internal namespace so that DSL users don't see it. It's internal after all.

Current Behavior

Director uses Internal.run_with_activation_context.

Possible Solution

I don't know.

julianbrost commented 1 year ago

This is based on my idea and we noticed references to this namespace in Director. But that's inside a function labeled "for testing purposes only, NOT production-ready" and the only use of that function is guarded by an $this->hasExperimental('live-creation'). Thus, I don't expect much breakage here.

So please see this issue as a heads-up notice for our plans and your chance to intervene if you see any trouble with that.

For reference, I also created a issue for this specific task, so if you want extra details, feel free to check out https://github.com/Icinga/icinga2/issues/9651.