Icinga / icingaweb2-module-fileshipper

Provide CSV, JSON, XML and YAML files as an Import Source for the Icinga Director and optionally ship hand-crafted additional Icinga2 config files
https://icinga.com/docs/director/latest/fileshipper/doc/02-Installation/
GNU General Public License v2.0
28 stars 13 forks source link

Comments starting with '#' are deprecated in ... #22

Closed swizzly closed 6 years ago

swizzly commented 6 years ago

I receive the following messages when I open in Director the Import Source / Modify Menu which uses the Fileshipper module (fd2c797) - though it also happens with older versions:

Deprecated: Comments starting with '#' are deprecated in Unknown on line 1 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 2 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 3 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 4 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 5 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 6 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Deprecated: Comments starting with '#' are deprecated in Unknown on line 7 in /usr/share/php/Icinga/File/Ini/IniParser.php on line 265

Context

The problem is only annoying and not serious, or at least for me the module seems to work fine, it just presents these messages, it would be fine to get rid of them. I am also not 100% percent sure, that this is related to the fileshipper module, but since it just pops up when I use it, I report it here.

Your Environment

Thomas-Gelf commented 6 years ago

Icinga Web 2.5 is strict about comments in INI files. Strictly speaking, # is not valid - commented lines must start with a semicolon (;). Guess there are lines starting with # in your /etc/icingaweb2/modules/fileshipper/*.ini

swizzly commented 6 years ago

Yeah, that solved the Problem. Many thanks!