search

Icinga / icingaweb2-module-graphite

The Graphite module for displays data stored in Graphite directly in the Icinga Web 2 interface.
https://icinga.com/docs/graphite/latest
GNU General Public License v2.0
73 stars 33 forks source link

Provide Permission to enable/disable the Menu entry #250

Open marcelfischer opened 3 years ago

marcelfischer commented 3 years ago

When I use Menu -> Graphite -> Services it generates huge load on graphite-web, icingaweb2 and my web browser because it loads many graphs depending on my "Default page size". For example 100 entries... I don't really see the use-case of loading random 25 or 100 graphs.

Expected Behavior

I would be nice to have an permission point in the graphite module to enable/disable the menu entry. Maybe graphs should also only load when someone uses the search bar and there should be a hard limit of api calls somehow.

Current Behavior

A "Default page size" of 100 leads to a not responding icinga web and generates high load on the graphite-web server.

Context

Your Environment

carraroj commented 3 years ago

ref/NC/701309

lippserd commented 3 years ago

I don't think that a permission makes sense here. It's actually about exactly that:

I don't really see the use-case of loading random N graphs.

We introduced a limit of two graphs a while ago, but that doesn't seem to work anymore. I think we should just fix this.

Tqnsls commented 3 years ago

Hi, the graphs_limit=2, which is set as default in the module, works, but it only limits the maximum graphs per host / service not the Default page size :) You could change the default values in the configuration.php of the module and for example append something like &host= to prohibit loading any graphs initially. But customizing the file could be overwritten when updating the module, of course.

sukhwinder33445 commented 2 years ago

Only the required graphs are fetched. The default value graphs_limit per object is set to 2, so only the first 25x2 graphs (or less) are fetched.