Icinga / icingaweb2-module-nagvis

NagVis integration into Icinga web 2
GNU General Public License v2.0
39 stars 22 forks source link

Invalid JSON response with PHP 8.1 #52

Closed mwaldmueller closed 1 year ago

mwaldmueller commented 1 year ago

With PHP 8.1.18 I get the following error when I want to add a Host/Service to a map:

nagvis

I also tested with PHP 8.0.28, that works on the same system. I'm not sure if this is related to the NagVis Module or NagVis itself (1.9.34).

Environment

PHP: 8.1.18 OS: Ubuntu 22.04.2 LTS (Jammy) Icinga Web 2.11.4 NagVis 1.9.34 NagVis Module: Current master with Icinga DB 140347ab4fae1c5b828b6020656fc18dd9bbbb6d

mwaldmueller commented 1 year ago

Issue for NagVis: https://github.com/NagVis/nagvis/issues/335

lippserd commented 1 year ago

Icinga DB uses timestamps with millisecond precision. But I think we could just cast that to int wherever we use last_state_change.

yhabteab commented 1 year ago

Icinga DB uses timestamps with millisecond precision.

This issue isn't caused by our module. Though, the upstream issue is fixed anyway, so I'm going to close this.