search

Icinga / icingaweb2-module-pdfexport

PDF export functionality for Icinga Web 2
GNU General Public License v2.0
31 stars 16 forks source link

Fix Chrome/Chromium version detection #11

Closed santuari closed 5 years ago

santuari commented 5 years ago

On RHEL 7, using Chromium PDF Export fails. This is caused by the version of Chome Google Chrome 73.0.3683.103 which is different from Chromium Chromium 73.0.3683.86 Fedora Project.

It should mitigate icingaweb2-module-reporting issue #7.

santuari commented 5 years ago

@Thomas-Gelf what do you think?

lippserd commented 5 years ago

I'll have a look at that one. Thanks for the PR!

Thomas-Gelf commented 5 years ago

@lippserd: instructions on how to install chromium (not chrome) might need improvement. This patch helps those running Chromium on CentOS/RHEL/Fedora as otherwise version detection will always fail.

@santuari: lgtm ;-)

bsdlme commented 5 years ago

Can the path to the chrom(e|ium) binary be made user configurable trough the web interface? E.g. on FreeBSD Chromium binary is at /usr/local/bin/chrome, so at the moment I have to change the path in library/Pdfexport/ProvidedHook/Pdfexport.php.

dnsmichi commented 5 years ago

You can do that inside the module's config.ini already, it just lacks the config forms. Try something like this, IIRC:

[chrome]
binary = "..."