Icinga / icingaweb2-module-pdfexport

PDF export functionality for Icinga Web 2
GNU General Public License v2.0
31 stars 16 forks source link

Show error messages and reasons instead of missing picture elements #28

Closed nilmerg closed 2 years ago

nilmerg commented 3 years ago

Is your feature request related to a problem? Please describe.

If external resources are part of a page, these may not load. If they're images, chrome shows a placeholder indicating a missing image.

Describe the solution you'd like

We should hook into the resource loading, and show our own placeholder for missing images. With the error reason and any additional details.

nilmerg commented 2 years ago

Not feasible. We can hook into it, but we cannot show helpful messages. The actual error reason is not available to Javascript. It however is available in the log since #32. I'd see this as sufficient, we just need to tell users to look into the log if there's a missing image.