Icinga / icingaweb2-module-puppetdb

PuppetDB module for Icinga Web 2 (ImportSource for Icinga Director)
12 stars 6 forks source link

documentation fix for installation #17

Closed jowrjowr closed 4 years ago

jowrjowr commented 5 years ago

The documentation here includes the following code block:

exec { "Generate combined .pem file for $puppetdb_host":
  command     => "cat private_keys/${my_certname}.pem certs/${my_certname}.pem > private_keys/${my_certname}_combined.pem",
  path        => ["/usr/bin", "/usr/sbin"],
  cwd         => $ssl_subdir,
  refreshonly => true
}

This won't work as listed due to cat being /bin/cat by standard, and NEVER sbin.

The fix is the following:

exec { "Generate combined .pem file for $puppetdb_host":
  command     => "cat private_keys/${my_certname}.pem certs/${my_certname}.pem > private_keys/${my_certname}_combined.pem",
  path        => ["/usr/bin", "/bin"],
  cwd         => $ssl_subdir,
  refreshonly => true
}
lippserd commented 5 years ago

Hi,

Thanks for the report. Any chance that you create a PR for your fix?

Best, Eric

Thomas-Gelf commented 4 years ago

Sorry for the delay and thanks for your effort!