search

Icinga / icingaweb2-module-vspheredb

The easiest way to monitor a VMware vSphere environment.
https://icinga.com/docs/vsphere/latest
GNU General Public License v2.0
100 stars 34 forks source link

Fix NVME disk counter + "Best_Wins" logic fix #540

Open adn77 opened 10 months ago

adn77 commented 10 months ago

We noticed that disk performance counters did not get into InfluxDB when using NVMe disks. This PR fixes this issue.

cla-bot[bot] commented 10 months ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @adn77

- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case. - If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.
adn77 commented 10 months ago

CLA has now been signed.

bobapple commented 10 months ago

@cla-bot check

adn77 commented 5 months ago

Sorry for pushing this in a single PR, there was a logical error in the evaluation of best_wins (absolute or percentage). The best_wins setting was only taken into account if BOTH values were already below a not-normal state.

This should be an or condition.