search

Icinga / icingaweb2-module-x509

Keeps track of certificates as they are deployed in a network environment.
https://icinga.com/docs/x509/latest/
GNU General Public License v2.0
107 stars 24 forks source link

Change hostname datatype in table x509_target #244

Closed hklemp closed 3 months ago

hklemp commented 3 months ago

Change the datatype of the hostname field in the tyble x509_target from varchar(255) to text. If you have a very long hostname or a large number of entries in an SNI map, an error will otherwise occur during scanning.

cla-bot[bot] commented 3 months ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @hklemp

- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case. - If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.
hklemp commented 3 months ago

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @hklemp

* If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case.

* If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

I've sign the CLA

bobapple commented 3 months ago

@cla-bot check

nilmerg commented 3 months ago

I wonder how you came up with host names exceeding this limit? Anyone I ask suggests that this is .. not common. And even, might not be supported by way more widespread tools than this Icinga Web module.

I can verify though, that SNI entries that exceed this limit are permitted. Such will trigger this issue. But the fix for this, would rather be to limit an entry's length so that it fits the schema's constraints.

hklemp commented 3 months ago

Mein Fehler, die Einträge in der SNI map waren nicht komma seperiert.