search

Icinga / icingaweb2-theme-company

Example theme for Icinga Web 2
https://www.icinga.com
37 stars 23 forks source link

Add example for header logo with text / tab title #7

Open dnsmichi opened 5 years ago

dnsmichi commented 5 years ago

Coming from https://github.com/Icinga/icingaweb2/issues/3093 I'd like to suggest an example for either:

I've seen that with Discourse themes, having such as an example tremendously helps the main product :)

Cheers, Michael

Thomas-Gelf commented 5 years ago

Regarding the browser title: this would require us to make the "Application Name" configurable, right now this is stored in a Constant. And: if implemented, this would be a setting in config.ini, would this fit your use-case? Reading the application name from a theme would have a notable (and not acceptable) performance impact.

"Logo with company name" is more an esthetic issue. It would waste space and/or look ugly. I usually create variants of the company logo, with different accents like a "testing" badge/banner, helping to distinct different instances. Of course, "text" would be a lot easier for people not used to creating images for the web.

dnsmichi commented 5 years ago

Ad tab title: Yes, definitely, thanks. The most simplest and fast way, I don't want to push this too much.

Ad logo title: I know about the text concerns vs the logo with an embedded text. Since this theme holds best practices and examples, I'm totally fine with a CSS entry which is commented out, just pushing users towards the right direction :)

Cheers, Michael