Icinga / puppet-icinga2-legacy

(legacy) Puppet module for Icinga 2 (EOL)
GNU General Public License v2.0
55 stars 93 forks source link

[dev.icinga.com #10752] Passing Variables from server.pp to features.pp is redundant #338

Open icinga-migration opened 8 years ago

icinga-migration commented 8 years ago

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10752

Created by thecrazybaker on 2015-11-30 19:03:19 +00:00

Assignee: (none) Status: New Target Version: (none) Last Update: 2015-11-30 19:44:26 +00:00 (in Redmine)


Lines 87 and 88 seem redundant since the features class already pulls those variables from the parent server class.

...from features.pp

  1. Enable Features for Icinga 2 class icinga2::server::features ( $enabled_features = $icinga2::server::server_enabled_features, $disabled_features = $icinga2::server::server_disabled_features, ) {

...from server.pp class {'icinga2::server::config':} ~> class {'icinga2::server::features': enabled_features => $server_enabled_features, disabled_features => $server_disabled_features, } ~>

icinga-migration commented 8 years ago

Updated by thecrazybaker on 2015-11-30 19:44:26 +00:00

You can ignore this. I just figured out what you are doing on the develop branch so this won't matter in the near future.