search

Icinga / terraform-provider-icinga2

Terraform Icinga2 provider
https://www.terraform.io/docs/providers/icinga2/
Mozilla Public License 2.0
21 stars 20 forks source link

Allow APIs to live outside of the document root #9

Closed joestump closed 6 years ago

joestump commented 6 years ago

Our Icinga2 API's path isn't in the document root.

talbright commented 6 years ago

This provider assumes that the icinga2 api is at the document root: http://127.0.0.1:5665/v1, but in some cases that might not be true.

For example, one might change the root by adding a re-write rule:

SSLProxyEngine On
RewriteRule      "^/icinga2_api/(.*)" "https://<ellided>:5665/$1" [P]
ProxyPass        "/icinga2_api"       "https://<ellided>:5665/"
ProxyPassReverse "/icinga2_api"       "https://<ellided>:5665/"
joestump commented 6 years ago

@talbright yup, this PR should address that issue. 🤞

talbright commented 6 years ago

@grubernaut any chance someone can take a look at this and #8?

grubernaut commented 6 years ago

@talbright would need to probably ping @tombuildsstuff or @radeksimko, as I left HC quite a while ago now :smile:

talbright commented 6 years ago

gotcha, thanks for answering though 🍻

talbright commented 6 years ago

@tombuildsstuff @radeksimko is there someone that can take a look at this? Thanks!

joestump commented 6 years ago

@tombuildsstuff @radeksimko any update on this? This PR is 3 months old now without any feedback. I have a fully commented out HCL file that means human fingers need to do things, which makes me really sad.

joestump commented 6 years ago

@radeksimko @tombuildsstuff is this provider abandoned? Help?

lrsmith commented 6 years ago

@joestump The provider is not abandoned. I am working to try and get these PRs merged in and looking at what it takes to be setup as a maintainer. These should get reviewed and merged in soon, hopefully.

joestump commented 6 years ago

🎉