search

Icon-Shelf / icon-shelf

SVG icon manager for developers.
https://icon-shelf.github.io
MIT License
284 stars 27 forks source link

made nav width adjustable #118

Closed prasoonmhwr closed 1 year ago

prasoonmhwr commented 1 year ago
prasoonmhwr commented 1 year ago

@MrRobz i think the check is failing because I added a new library(re-sizable) in package.json, any idea how this can be fixed.

prasoonmhwr commented 1 year ago

@MrRobz Even after updating lock file its failing

MrRobz commented 1 year ago

@MrRobz Even after updating lock file its failing

Yup I can see that. Wondering what could be the issue.

prasoonmhwr commented 1 year ago

@MrRobz Even after updating lock file its failing

Yup I can see that. Wondering what could be the issue.

I think this is happening becasue of the npm and node version mismatch, I am using

Node: v16.15.0 npm: 8.5.5

what is the version used in project?

MrRobz commented 1 year ago

@MrRobz Even after updating lock file its failing

Yup I can see that. Wondering what could be the issue.

I think this is happening becasue of the npm and node version mismatch, I am using

Node: v16.15.0 npm: 8.5.5

what is the version used in project?

The github action that runs lint and type checks have node 16 and npm 8.

prasoonmhwr commented 1 year ago

so i think its not the version issue then

MrRobz commented 1 year ago

so i think its not the version issue then

What puts me off is, the github action logs says

npm ERR! Missing: @types/estree@0.0.51 from lock file npm ERR! Missing: @webassemblyjs/ast@1.11.1 from lock file npm ERR! Missing: @webassemblyjs/wasm-edit@1.11.1 from lock file

But packages are not there in package-lock files. Why is it trying to install them !

prasoonmhwr commented 1 year ago

Not sure , Actually I am new to github so no experience with github actions, sorry about that.

prasoonmhwr commented 1 year ago

@MrRobz Found something on the internet, it was an accepted answer on stackoverflow, can we try this?

     - name: Install dependencies
        run: |
          if [ -e yarn.lock ]; then
          yarn install --frozen-lockfile
          elif [ -e package-lock.json ]; then
          npm ci
          else
          npm i
          fi
prasoonmhwr commented 1 year ago

Thanks for your changes @prasoonmhwr . I don't see any thing wrong with the PR that is causing the github action to fail. Could be something wrong with the action runns in github for forked repos.

I'll try merging to a separate branch in icon-shelf repo test it and then merge to the main repo.

Thank again. This is amazing work.

@MrRobz Please let me know if it gets merged into the main branch . It will make me feel happy :)

MrRobz commented 1 year ago

@MrRobz Found something on the internet, it was an accepted answer on stackoverflow, can we try this?

     - name: Install dependencies
        run: |
          if [ -e yarn.lock ]; then
          yarn install --frozen-lockfile
          elif [ -e package-lock.json ]; then
          npm ci
          else
          npm i
          fi

Got it working here https://github.com/Icon-Shelf/icon-shelf/pull/121 it was something to do with package-lock file. I reverted package-lock file to original version and did npm install re-resizable. Merging it to main now.