search

Iconica-Development / flutter_chat

Add a (personal or group) chat to your Flutter-application.
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Feature/add emoji support #104

Closed CodeThomnics closed 3 weeks ago

PureTryOut commented 1 month ago

I don't think we should add emoji support to the package. Sending emoji's should really be handled by the keyboard of the operating system in use, it's not something every application should manually do.

Also please add some context to your PR's. Why do you want this feature? Please use the description field :smile:

CodeThomnics commented 1 month ago

I get you comment. I wanted to add emoji support for different platforms and able to send them everywhere and correctly rendered. I will add this to the description next time and motivate my reason. Thanks for the feedback

PureTryOut commented 1 month ago

What are those different platforms though? At least Linux (KDE Plasma that is, pretty sure GNOME too) and macOS have their own emoji selectors. So do Android and iOS. I'm unsure about Windows but I find it hard to believe they don't have something either.

With that you have basically all platforms covered (excluding web, those use the same emoji pickers as all the other platforms ofc).

CodeThomnics commented 1 month ago

Well, i get this result on KDE with the emoji selector. I don't know if it is a good result. It's different from what the emoji selector shows image

PureTryOut commented 1 month ago

That's a system problem, you're missing the right font. I think font-noto-emoji (check your distribution for the right package name) should do it but you'll have to verify it for yourself.

CodeThomnics commented 1 month ago

i have it installed but it doesn't fix it. I think flutter doesn't render it