search

Iconscout / react-unicons

1000+ vector icons as easy to use React Components
https://iconscout.com/unicons
Other
334 stars 39 forks source link

Update to React 16 #1

Closed bez4pieci closed 5 years ago

bez4pieci commented 5 years ago

There is no effect on the code and output. For people working on react 16 shaves 30k off the bundle size since no files from react 15 need be included.

tarunmangukiya commented 5 years ago

So, this won't work for React <15. How about keeping it >16.0.0 rather than 16.8.*? I am not much sure about usage of each version!

bez4pieci commented 5 years ago

I have found version major comparison here and minor here. Version 15 is still more popular than 16, while 16.8 is most popular among all 16.* versions. perhaps release a new minor version of react-unicons with react v16? React 15 users could stay with the current version and continue getting updates with new icons through patch versions.

tarunmangukiya commented 5 years ago

That sounds good! keeping major/minor versions.

How about keeping >15.0.0? That'll be supported for both versions.

https://docs.npmjs.com/files/package.json#dependencies

bez4pieci commented 5 years ago

That would satisfy both 15 and 16, but watch out for breaking changes with react 17. perhaps 15.0.0 - 16.9999.9999 or >=15.0.0 <17.0.0?

tarunmangukiya commented 5 years ago

Ya, let's keep >=15.0.0 <17.0.0

bez4pieci commented 5 years ago

@tarunmangukiya i updated the PR