Update react version in package.json

Iconscout / react-unicons

1000+ vector icons as easy to use React Components

https://iconscout.com/unicons

Other

334 stars 39 forks source link

Update react version in package.json #28

Open eddiecooro opened 3 years ago

eddiecooro commented 3 years ago

The previous version notation was accurate before react team has released the react@17 and react-dom@17 Now we know these versions contain almost no breaking change at all! So I guess it's safe to kick the can down the line till a future react@18 version :sweat_smile:

We have issues with the current version since we upgraded to new react-scripts with react@17 and we had to work around it by using the resolutions field in package.json But I think that wouldn't be that easy to solve for guys that are using npm.

eddiecooro commented 3 years ago

On the same note, why you have react in both dependencies and peerDependencies fields? Shouldn't one of them get moved to devDependencies?
Also, why we don't have react-dom as a peerDependency too?

michiomochi commented 3 years ago

I want this changes too!

@tarunmangukiya Please review it 🙏