Open Tooni opened 1 year ago
@rankarpan any chance this could get a review? who is maintaining this repository nowadays?
Any way this PR can get some love?
@tarunmangukiya and @rankarpan please review and merge this. Same update to Iconscout/react-unicons-solid would be aprciated.
generate.js
to generate that type declaration fileThis is a simple way to address https://github.com/Iconscout/react-unicons/issues/25, the TypeScript support issue.
The other PR addressing it is https://github.com/Iconscout/react-unicons/pull/50. It's great but is a full conversion. I thought perhaps the reason it wasn't merged is that it has too many changes.
My PR adds the types in a more minimal way, by adding solely the declaration file
index.d.ts
. This is enough to greatly improve the development experience for anyone using TypeScript i.e. most major tech companies.Some screenshots of it working in VS Code: